Skip to content

style: fix all ruff check, format, and mypy errors#2

Merged
deviantintegral merged 4 commits into
mainfrom
copilot/fix-ruff-check-errors
Feb 25, 2026
Merged

style: fix all ruff check, format, and mypy errors#2
deviantintegral merged 4 commits into
mainfrom
copilot/fix-ruff-check-errors

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 25, 2026

Resolve all ruff lint, formatting, and mypy type checking errors across the codebase.

  • E501 line-too-long (protocol.py, screens.py): Rewrap long lines — split debug call args, extract format string to local, move inline comment above code
  • UP035 + TC003 (tui/app.py): Import Awaitable from collections.abc and move into TYPE_CHECKING block
  • TC002 (tui/auth_screen.py): Move ComposeResult into TYPE_CHECKING block (only used in annotations, from __future__ import annotations is active)
  • I001 (tui/app.py): Fix import sort order as a side effect of the above
  • ruff format: Applied ruff format . across all 19 files that were not conforming to the canonical formatter style (source and test files)
  • mypy arg-type (b2c_login.py): Wrap url string with yarl.URL() for filter_cookies which expects a URL type
  • mypy arg-type (heat_mode_screen.py, flame_speed_screen.py, fire_select_screen.py): Annotate Button variant variables with ButtonVariant type alias to satisfy the Literal expectation
  • mypy union-attr (tui/app.py): Add None guard for sys.__stderr__ before accessing .fileno(), .buffer, and .flush()

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…king blocks

Co-authored-by: deviantintegral <255023+deviantintegral@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix errors found by ruff check Fix all ruff check errors Feb 25, 2026
@deviantintegral deviantintegral marked this pull request as ready for review February 25, 2026 21:02
@deviantintegral
Copy link
Copy Markdown
Owner

@copilot fix the lint and test errors in the CI job.

Co-authored-by: deviantintegral <255023+deviantintegral@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Feb 25, 2026

@copilot fix the lint and test errors in the CI job.

Fixed in 1fe8688. The ruff format --check . failure (19 files needing reformatting) is now resolved — ran ruff format . across the entire codebase. Both ruff check . and ruff format --check . pass, and all 989 tests pass.

Note: The "Conventional Commits" check fails because the PR title needs a conventional prefix (e.g. style: Fix all ruff check errors). That requires a PR title change which I can't do — you'll need to update it manually.

Copilot AI changed the title Fix all ruff check errors style: fix all ruff check and format errors Feb 25, 2026
@deviantintegral
Copy link
Copy Markdown
Owner

@copilot can you fix the type checking errors in the lint job?

Co-authored-by: deviantintegral <255023+deviantintegral@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Feb 25, 2026

@copilot can you fix the type checking errors in the lint job?

Fixed in cc654d4. All 7 mypy errors resolved:

  • b2c_login.py — wrapped url with yarl.URL() for filter_cookies (updated test to match)
  • heat_mode_screen.py, flame_speed_screen.py, fire_select_screen.py — annotated variant as ButtonVariant
  • app.py — added None guard for sys.__stderr__

ruff check, ruff format --check, mypy src/, and all 989 tests pass.

Copilot AI changed the title style: fix all ruff check and format errors style: fix all ruff check, format, and mypy errors Feb 25, 2026
@deviantintegral deviantintegral merged commit 7c4d0e5 into main Feb 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants